dashy icon indicating copy to clipboard operation
dashy copied to clipboard

:bug: Fix a bug in RssFeed widget that crashes on small feeds.

Open SharpCoder opened this issue 1 year ago • 1 comments

SharpCoder Quick SharpCoder /master → Lissy93/dashy Commits: 1 | Files Changed: 1 | Additions: 0 Label Powered by Pull Request Badge

RssFeed would always default to this.limit for the size of the feed item array. Feeds that came in with fewer items than the limit would throw an exception, because the loop would then try to iterate over non-existent entries.

Category: Bugfix

Overview The RssFeed widget would always try to read this.limit items from the array. For feeds with fewer items, it would throw an exception. My change will populate the lesser between: (the actual qty of items, or the limit).

Issue Number (if applicable) N/A

New Vars (if applicable) N/A

Screenshot (if applicable) N/A

Code Quality Checklist (Please complete)

  • [x] All changes are backwards compatible
  • [x] All lint checks and tests are passing
  • [x] There are no (new) build warnings or errors
  • [x] (If a new config option is added) Attribute is outlined in the schema and documented
  • [x] (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • [x] (If significant change) Bumps version in package.json

SharpCoder avatar Feb 14 '25 04:02 SharpCoder

Deploy Preview for dashy-dev ready!

Name Link
Latest commit b6ae17aad17a2c6a61b1027ad7ba7c33fddf5006
Latest deploy log https://app.netlify.com/sites/dashy-dev/deploys/67aeccc2b64aed0008f992a3
Deploy Preview https://deploy-preview-1817--dashy-dev.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Feb 14 '25 04:02 netlify[bot]