Lua-Modules icon indicating copy to clipboard operation
Lua-Modules copied to clipboard

fix(Opponent): opponentname condition in PlayerExtCustom faulty

Open robbai opened this issue 1 year ago • 3 comments

Summary

Opponent.resolve gsubs for underscores before calling to this function, but opponentname is stored with spaces.

How did you test this change?

/dev

robbai avatar Nov 04 '24 01:11 robbai

Would it not be better to set in match2 to pagify?

Rathoz avatar Nov 07 '24 14:11 Rathoz

Would it not be better to set in match2 to pagify?

might cause issues in other places, e.g. GTL etc

hjpalpha avatar Nov 07 '24 15:11 hjpalpha

Would it not be better to set in match2 to pagify?

might cause issues in other places, e.g. GTL etc

That's going through legacy, so just need to make sure it's kept the same there as today

Rathoz avatar Nov 07 '24 16:11 Rathoz