Lua-Modules icon indicating copy to clipboard operation
Lua-Modules copied to clipboard

feat(infobox): create storage for extra roles on hearthstone

Open iamentry opened this issue 1 year ago • 6 comments

Summary

Adds role storage for hearthstone. Lots of conversions have been done on tournament pages to move over to Broadcaster cards and subsequently, pages have been made for Casters.

How did you test this change?

testing live https://liquipedia.net/hearthstone/Dragonrider

iamentry avatar Aug 10 '24 23:08 iamentry

Missing the reason for why it's needed

Rathoz avatar Aug 12 '24 07:08 Rathoz

Missing the reason for why it's needed

Caster pages are being regularly created and thus need proper storage of the roles to be able to track them in things such as the Player Portal

iamentry avatar Aug 12 '24 18:08 iamentry

Any particular reason why 2 roles are needed? Any reason why the commons display is not enough and has to be modified? etc

Rathoz avatar Aug 13 '24 07:08 Rathoz

Any particular reason why 2 roles are needed? Any reason why the commons display is not enough and has to be modified? etc

The caster and host roles are so far the only ones used on any pages. I could add the full list of roles now just to account for anything in the future like most other wikis have.

About the commons display: The wiki needs these roles to be stored so they can be displayed in the player portal and have proper categories to link to. Sorry if I'm misunderstanding anything

iamentry avatar Aug 14 '24 06:08 iamentry

I mean 2 role displays, commons will display one role out of the box. Is there any example where displaying 2 roles is a must?

Rathoz avatar Aug 14 '24 07:08 Rathoz

I mean 2 role displays, commons will display one role out of the box. Is there any example where displaying 2 roles is a must?

I looked around on the wiki and couldn't come up with an argument for it. Kicked

iamentry avatar Aug 16 '24 15:08 iamentry