Lua-Modules icon indicating copy to clipboard operation
Lua-Modules copied to clipboard
verified publisher icon Liquipedia

fix(RL Player/Ext): use placement data instead of obsolete datapoint

Open hjpalpha opened this issue 1 year ago • 3 comments

it working #depends on #4247 but there is no harm in already merging it

Summary

Use placement data instead of obsolete datapoint in Rocketleagues PlayerExtCustom.fetchTeamHistoryEntry fucntion so it actually can fetch teams again. Note: this means that RLs PlayerExtCustom.fetchTeamHistoryEntry is still only usable directly on pages with PrizePool/ParticipantTable and still only works for solo opponents and not for duo etc.

How did you test this change?

dev

hjpalpha avatar May 02 '24 11:05 hjpalpha

@robbai can you supply a page where i can test this?

hjpalpha avatar May 02 '24 12:05 hjpalpha

@robbai can you supply a page where i can test this?

https://liquipedia.net/rocketleague/Feer/Fiesta

robbai avatar May 02 '24 12:05 robbai

fyi failed check only due to npm dependency stuff --> #4261 should fix that

hjpalpha avatar May 04 '24 16:05 hjpalpha