Lua-Modules icon indicating copy to clipboard operation
Lua-Modules copied to clipboard

Refactor various Infoboxes into Infobox Unit

Open FenrirWulf opened this issue 1 year ago • 4 comments

We have various infoboxes that can/should be refactored into 1 Infobox as the base instead of multiple infoboxes.

  • [ ] Hero
  • [ ] Character
  • [ ] Champion
  • [ ] Operator
  • [ ] Agent

FenrirWulf avatar Feb 09 '24 02:02 FenrirWulf

only unit and character exist on the git repo and they are quite different (you created the character one due to that >2 years ago)

champion, operator and agent should all be able to use one of the two as a base

hjpalpha avatar Feb 09 '24 06:02 hjpalpha

Unit and Character should be kept separate I believe. Character is generally more like a Champion/Hero/Agent/Operator; while Unit is something that you buy in an RTS, like a ~~Space Marine~~ Terran Marine

Rathoz avatar Feb 09 '24 08:02 Rathoz

Unit and Character should be kept separate I believe. Character is generally more like a Champion/Hero/Agent/Operator; while Unit is something that you buy in an RTS, like a ~Space Marine~ Terran Marine

fun fact the german translation calls them "Space Marine" instead of just "Marine" (like in the neglish version)

hjpalpha avatar Feb 09 '24 09:02 hjpalpha

I mean.. sure.. but we have already combined Champion & God infoboxes into Unit. Additionally, F1 uses Unit for Engine and Car, and OW is currently getting its Hero Infobox based off Unit as well.

The base version according to our current practice isnt that important. The more important part is the custom module built for the wiki. Since we can always add wiki specific LPDB saving, or adjust the display of things. image

FenrirWulf avatar Feb 09 '24 10:02 FenrirWulf