Lua-Modules icon indicating copy to clipboard operation
Lua-Modules copied to clipboard

Remove bottom margin from final infobox match

Open robbai opened this issue 2 years ago • 4 comments

Summary

Add !important to .infobox_matches_content:last-child's margin-bottom so that it overrides table.infobox_matches_content's margin-bottom

How did you test this change?

Inspect element

Before: After:
Before After

robbai avatar Dec 04 '23 11:12 robbai

Since !important is already used so much on the website I would try to avoid using it even more. So if possible, you could try to make the css more specific, that way you can override it without using important. You can try a tool like https://specificity.keegan.st/ But if it's too much to untangle I understand it as well.

liquidely avatar Dec 04 '23 13:12 liquidely

Since !important is already used so much on the website I would try to avoid using it even more. So if possible, you could try to make the css more specific, that way you can override it without using important. You can try a tool like https://specificity.keegan.st/ But if it's too much to untangle I understand it as well.

The initial definition already uses !important for some reason, so this isn't easily possible without refactoring that as well, right?

mbergen avatar Dec 04 '23 15:12 mbergen

Since !important is already used so much on the website I would try to avoid using it even more. So if possible, you could try to make the css more specific, that way you can override it without using important. You can try a tool like https://specificity.keegan.st/ But if it's too much to untangle I understand it as well.

The initial definition already uses !important for some reason, so this isn't easily possible without refactoring that as well, right?

Yes it might require some refactoring, so if it's too much hassle ignore my comment.

liquidely avatar Dec 04 '23 18:12 liquidely

Note that merging this change will require changes to some matchtickers on main page that have a link to "See more matches" added after the last match, as these often have a negative margin-top to account for the bug fixed by this PR.

mbergen avatar Dec 05 '23 12:12 mbergen