feat(FilterButtons) Create Module:FilterButtons
Summary
This module extracts the setup of FilterButtons used in Module:TournamentsList for future refactoring of said module or potential separate usage (e.g. Portal:Tournaments to filter by TG/1v1?). PR is mostly for code review, could also add a header and add it to git if that is wanted.
- [ ] CSS still needs cleanup via appropriate classes, but i'm ~~neither an interface admin~~ nor a frontend dev.
How did you test this change?
Simple test here, extensive tests TBD
Btw, i'm not sure whether it is possible to properly annotate fields of a class as optional function, while also specifiying the function:
Looks like what works for params does not work for fields.
Btw, i'm not sure whether it is possible to properly annotate fields of a class as optional function, while also specifiying the
Looks like the annotation is actually correctly parsed
@Rathoz do you want this added to the git? if so, which directory?
imo add it but maybe rename it since it seems pretty specific for tournaments list (right?), also due to that maybe use tournaments_list as folder(?)
Refactored CSS and tested new setup in my dev env: http://killian.wiki.tldev.eu/rocketleague/MainPageTest Tried to make sure it would not collide with the existing tournament list filters by reusing the same CSS rules into the different classes