Lua-Modules icon indicating copy to clipboard operation
Lua-Modules copied to clipboard

feat(FilterButtons) Create Module:FilterButtons

Open mbergen opened this issue 2 years ago • 4 comments

Summary

This module extracts the setup of FilterButtons used in Module:TournamentsList for future refactoring of said module or potential separate usage (e.g. Portal:Tournaments to filter by TG/1v1?). PR is mostly for code review, could also add a header and add it to git if that is wanted.

  • [ ] CSS still needs cleanup via appropriate classes, but i'm ~~neither an interface admin~~ nor a frontend dev.

How did you test this change?

Simple test here, extensive tests TBD

mbergen avatar Sep 02 '23 14:09 mbergen

Btw, i'm not sure whether it is possible to properly annotate fields of a class as optional function, while also specifiying the function: image Looks like what works for params does not work for fields. image

mbergen avatar Sep 11 '23 13:09 mbergen

Btw, i'm not sure whether it is possible to properly annotate fields of a class as optional function, while also specifiying the

Looks like the annotation is actually correctly parsed image

mbergen avatar Sep 11 '23 13:09 mbergen

@Rathoz do you want this added to the git? if so, which directory?

mbergen avatar Sep 11 '23 18:09 mbergen

imo add it but maybe rename it since it seems pretty specific for tournaments list (right?), also due to that maybe use tournaments_list as folder(?)

hjpalpha avatar Sep 11 '23 18:09 hjpalpha

Refactored CSS and tested new setup in my dev env: http://killian.wiki.tldev.eu/rocketleague/MainPageTest Tried to make sure it would not collide with the existing tournament list filters by reusing the same CSS rules into the different classes

KilMer56 avatar Jun 17 '24 10:06 KilMer56