Server.js icon indicating copy to clipboard operation
Server.js copied to clipboard

Replace Request dependency

Open marcelomachado opened this issue 3 years ago • 3 comments

Since request has been deprecated, see https://github.com/request/request/issues/3142 wouldn't it be interesting to replace it to another library such as axios?

marcelomachado avatar Nov 04 '22 19:11 marcelomachado

Yes, we definitely need to replace it! :-) I've had good experiences with node-fetch in other projects, so I can recommend that one (especially since fetch support is native in Node 18).

rubensworks avatar Nov 05 '22 08:11 rubensworks

What do you think about doing this little by little? For example, in the datasource I am creating I have already added this dependency: https://github.com/marcelomachado/Server.js/commit/d29c3323f984d13731b16c66422d38a19e29ca20

marcelomachado avatar Nov 08 '22 05:11 marcelomachado

Sure, that's fine by me :)

rubensworks avatar Nov 08 '22 06:11 rubensworks