OpenCSD icon indicating copy to clipboard operation
OpenCSD copied to clipboard

Add #include <cstdlib> for strtol and getenv.

Open alexfh opened this issue 1 year ago • 3 comments

Recent changes to LLVM libc++ discovered missing #includes. This code is using strtol and getenv, so it needs to include <cstdlib> or <stdlib.h> - whichever is more consistent with the the project coding style.

alexfh avatar Nov 08 '24 23:11 alexfh

@mikel-armbb would you be the right reviewer for this?

alexfh avatar Nov 11 '24 16:11 alexfh

Hi,

Thanks for this.

I'll add this in the next opencsd patch release.

Mike

mikel-armbb avatar Nov 12 '24 21:11 mikel-armbb

@alexfh : do you have specific version where this is failiing. We are currently using Apple Clang 14.0.3 without issues.

Thanks

Mike

mikel-armbb avatar Nov 13 '24 13:11 mikel-armbb

Fixed in v1.5.6

mikel-armbb avatar Feb 26 '25 14:02 mikel-armbb