feat[logger] update mlflow limit for parameters length log
feat[logger] update mlflow limit for parameters length log using mlflow package
What does this PR do?
Update the mlflow logger to take into account limits defined inside mlflow package. As of now, it only include limit for params logging.
Before submitting
- [ ] Was this discussed/agreed via a GitHub issue? (not for typos and docs)
- [x] Did you read the contributor guideline, Pull Request section?
- [x] Did you make sure your PR does only one thing, instead of bundling different changes together?
- [x] Did you make sure to update the documentation with your changes? (if necessary)
- [x] Did you write any new necessary tests? (not for typos and docs) Not needed
- [x] Did you verify new and existing tests pass locally with your changes?
- [x] Did you list all the breaking changes introduced by this pull request? No breaking changes because of fallback
- [x] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)
PR review
Anyone in the community is welcome to review the PR. Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
- [x] Is this pull request ready for review? (if not, please submit in draft mode)
- [ ] Check that all items from Before submitting are resolved
- [ ] Make sure the title is self-explanatory and the description concisely explains the PR
- [ ] Add labels and milestones (and optionally projects) to the PR so it can be classified
📚 Documentation preview 📚: https://pytorch-lightning--20636.org.readthedocs.build/en/20636/
@lantiga, @Borda, @tchaton, @justusschock, @ethanwharris, is there any change to see this pull request merged for the next release ?
@bastienjalbert seems some tests are still failing :)
True, I'll make patchs in coming days. I think that just a mock issue. Thank you !
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need further help see our docs: https://lightning.ai/docs/pytorch/latest/generated/CONTRIBUTING.html#pull-request or ask the assistance of a core contributor here or on Discord. Thank you for your contributions.
@Borda I applied a fix on the modified part
@Borda I applied a fix on the modified part
pls, reach out to @williamFalcon or @lantiga
Hello @williamFalcon , @lantiga Did you take a look at the PR ?
Do I need to add anything ? @williamFalcon @lantiga