pytorch-lightning icon indicating copy to clipboard operation
pytorch-lightning copied to clipboard

feat[logger] update mlflow limit for parameters length log

Open bastienjalbert opened this issue 1 year ago • 8 comments

feat[logger] update mlflow limit for parameters length log using mlflow package

What does this PR do?

Update the mlflow logger to take into account limits defined inside mlflow package. As of now, it only include limit for params logging.

Before submitting
  • [ ] Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • [x] Did you read the contributor guideline, Pull Request section?
  • [x] Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [x] Did you make sure to update the documentation with your changes? (if necessary)
  • [x] Did you write any new necessary tests? (not for typos and docs) Not needed
  • [x] Did you verify new and existing tests pass locally with your changes?
  • [x] Did you list all the breaking changes introduced by this pull request? No breaking changes because of fallback
  • [x] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR. Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • [x] Is this pull request ready for review? (if not, please submit in draft mode)
  • [ ] Check that all items from Before submitting are resolved
  • [ ] Make sure the title is self-explanatory and the description concisely explains the PR
  • [ ] Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--20636.org.readthedocs.build/en/20636/

bastienjalbert avatar Mar 11 '25 14:03 bastienjalbert

@lantiga, @Borda, @tchaton, @justusschock, @ethanwharris, is there any change to see this pull request merged for the next release ?

bastienjalbert avatar Mar 26 '25 08:03 bastienjalbert

@bastienjalbert seems some tests are still failing :)

Borda avatar Apr 07 '25 11:04 Borda

True, I'll make patchs in coming days. I think that just a mock issue. Thank you !

bastienjalbert avatar Apr 07 '25 19:04 bastienjalbert

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need further help see our docs: https://lightning.ai/docs/pytorch/latest/generated/CONTRIBUTING.html#pull-request or ask the assistance of a core contributor here or on Discord. Thank you for your contributions.

stale[bot] avatar Apr 26 '25 19:04 stale[bot]

@Borda I applied a fix on the modified part

bastienjalbert avatar May 22 '25 13:05 bastienjalbert

@Borda I applied a fix on the modified part

pls, reach out to @williamFalcon or @lantiga

Borda avatar May 23 '25 13:05 Borda

Hello @williamFalcon , @lantiga Did you take a look at the PR ?

bastienjalbert avatar Jun 05 '25 06:06 bastienjalbert

Do I need to add anything ? @williamFalcon @lantiga

bastienjalbert avatar Jul 16 '25 08:07 bastienjalbert