pytorch-lightning icon indicating copy to clipboard operation
pytorch-lightning copied to clipboard

CI: Update `base-ipu` docker image

Open akihironitta opened this issue 3 years ago • 0 comments

What does this PR do?

  • Resolves timeout in master due to very slow dependency resolution by conda. (from >100min to <10min)
  • Most of the change comes from the base-cuda dockerfile.

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • [ ] Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • [x] Did you read the contributor guideline, Pull Request section?
  • [x] Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • [n/a] Did you verify new and existing tests pass locally with your changes?
  • [n/a] Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR. Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • [x] Is this pull request ready for review? (if not, please submit in draft mode)
  • [x] Check that all items from Before submitting are resolved
  • [x] Make sure the title is self-explanatory and the description concisely explains the PR
  • [x] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @carmocca @akihironitta @borda

akihironitta avatar Aug 06 '22 01:08 akihironitta

I'll keep this PR as draft so that we don't merge it before verifying it in the IPU CI.

akihironitta avatar Aug 15 '22 11:08 akihironitta

I'll keep this PR as draft so that we don't merge it before verifying it in the IPU CI.

This PR is basically ready, but I'd like to check in advance if the docker image built from this dockerfile works in our CI...

Could anyone help with merging this PR?

akihironitta avatar Sep 09 '22 03:09 akihironitta

Hi, @akihironitta, what do you need help with? I'm here :slightly_smiling_face:

otaj avatar Sep 15 '22 06:09 otaj