lightning-thunder icon indicating copy to clipboard operation
lightning-thunder copied to clipboard

docker: install cudnn with source build only (PR2456)

Open Borda opened this issue 1 year ago • 0 comments

Before submitting

  • [x] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • [x] Did you read the contributor guideline, Pull Request section?
  • [x] Did you make sure to update the docs?
  • [x] Did you write any new necessary tests?

What does this PR do?

The problem is:

  • torch 2.2 downloads cudnn from pypi
    • this is 8.9.2
  • thunder's docker container also has cudnn from deb pkg
    • https://github.com/Lightning-AI/lightning-thunder/blob/main/dockers/ubuntu-cuda/Dockerfile#L83
    • this is 8.9.7
  • FE v1.2 prefers cudnn from deb over pypi
    • and hence there is a mismatch

so far, we expect two kinds of users:

  • mainstream - install PT from the latest published (this kind of user wont play with unstill some system package and reinstall with another)
  • developer - fine to compile news from the source and, in such case also set any desired cudnn versio

PR review

Anyone in the community is free to review the PR once the tests have passed. If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

Borda avatar Mar 21 '24 10:03 Borda