halfbrown icon indicating copy to clipboard operation
halfbrown copied to clipboard

Remove hashbrown dependency?

Open richarddd opened this issue 2 years ago • 3 comments

Maybe i'm missing something here but since Rust 1.36, hashbrown is now the HashMap implementation for the Rust standard library so is the dependency needed?

And then you can use use the default HashMap with an ahash or fxhash or pull in that dependency. fxhash was the most performant (not cryptographically safe) when used in rustc https://nnethercote.github.io/perf-book/hashing.html but of many cases ahash is faster

Or even better, use the default hashset and feature gate fxhash or ahash algorithms defaulting to ahash 🥇

richarddd avatar Feb 07 '24 07:02 richarddd

The standard HashMap hasn't stabilized the RawEntry API which hashbrowns (and halfbrown) exposes once that is stabelized in core-rust we don't need hashbrowns any more :)

Licenser avatar Feb 07 '24 18:02 Licenser

Perhaps, release halfbrown 0.2.5 with the latest hashbrown in the meantime?

#30

jqnatividad avatar Mar 04 '24 16:03 jqnatividad

@Licenser would you consider upgrading to latest halfbrown? I'm getting duplicate deps on hashbrown v0.15.2 and this v0.14.5

richarddd avatar Dec 25 '24 06:12 richarddd