OpenPDF icon indicating copy to clipboard operation
OpenPDF copied to clipboard

Errors in indentation and tab positions

Open jansorby opened this issue 3 years ago • 2 comments

The widt() method of a TAB PdfChunk must return 0.0f to avoid it from advancing the position away from the given tab-position. It used to move to the right the width of the placeholder character in the chunk.

When using a negative value for setFirstLineIndent, the original width of the PdfLine must be adjusted. If not, the calculation of the remaining width after inserting a TAB will be wrong. The result will be that the line may be broken at the wrong position, making both the first and second line too short.

Related Issue: #790 Related Issue: #791

Compatibilities Issues

Existing code using TAB may have their position moved slightly to the left.

jansorby avatar Aug 17 '22 07:08 jansorby

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Aug 17 '22 07:08 sonarqubecloud[bot]

Hi @jansorby, the checkstyle problems were fixed on master. Can you please rebase your branch onto OpenPdf/master?

asturio avatar Sep 12 '22 17:09 asturio

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Jul 25 '23 08:07 sonarqubecloud[bot]

Hi @asturio, sorry for taking so long to answer. I am not familiar with the terminologies on github, so I don't understand what you are asking me to do. I don't understand what checkstyle problems is, and I don't understand what it means to rebase my branch onto Master. Does it mean that my issues have been fixed on Master? Should I implement my changes on Master? I have also reported a new issue #927 that I also have a suggested fix for on this branch. Sorry for being so ignorant, I am not so young anymore and struggles a bit with new ways of doing things. :-)

jansorby avatar Jul 26 '23 08:07 jansorby