OpenPDF icon indicating copy to clipboard operation
OpenPDF copied to clipboard

Skipping eliminateSharedStreams() method call.

Open netmackan opened this issue 3 years ago • 4 comments

Description of the new Feature/Bugfix

The change is that creating a PdfReader does not mean that the eliminateSharedStreams() method is called. This solves #763 which breaks certain PDF documents by doing this. Instead if elimination of shared streams is needed in some case the public method can be called explicitly.

Related Issue: #763

Unit-Tests for the new Feature/Bugfix

  • [ ] Unit-Tests added to reproduce the bug
  • [ ] Unit-Tests added to the added feature

Compatibilities Issues

Is anything broken because of the new code? Any changes in method signatures? Method signatures are the same but if elimination of shared streams are required for some use case then this method needs to be called explicitly from now.

Testing details

Any other details about how to test the new feature or bugfix? Tested with PDF documents having this issue. See link to document in the ticket.

netmackan avatar Jun 23 '22 11:06 netmackan

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Jun 23 '22 11:06 sonarqubecloud[bot]

Hi @netmackan , the checkstyle problems were fixed on master. Can you please rebase your branch onto OpenPdf/master?

asturio avatar Sep 12 '22 16:09 asturio

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Sep 14 '22 08:09 sonarqubecloud[bot]

Hi @asturio, I have rebased now I believe. Cheers,

netmackan avatar Sep 14 '22 09:09 netmackan

Anything preventing this from getting merged?

netmackan avatar Nov 14 '22 11:11 netmackan