OpenPDF icon indicating copy to clipboard operation
OpenPDF copied to clipboard
verified publisher icon LibrePDF

fix the issue #659: PdfPRow setMayNotBreak property

Open haha989 opened this issue 3 years ago • 3 comments

Description of the new Feature/Bugfix

Describe here how you fixed the bug, or implemented the new feature. I add the feature of the issue mentioned.

Related Issue: #659

Unit-Tests for the new Feature/Bugfix

  • [ ] Unit-Tests added to reproduce the bug
  • [2] Unit-Tests added to the added feature

Compatibilities Issues

Is anything broken because of the new code? Any changes in method signatures? No

Testing details

Any other details about how to test the new feature or bugfix? Test the new feature using 2 test case.

haha989 avatar May 28 '22 12:05 haha989

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar May 28 '22 15:05 sonarqubecloud[bot]

Hi @haha989 , it is a nice PR, but I'm missing the code where the flag is really used. In PdfPRow you can set the flag. In PdfPTable you can also set the flag. And in your test you also set the flag and tests if the flag is set. But there is no code, that checks if the flag is set, having a different behavior.

asturio avatar Jun 03 '22 13:06 asturio

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Sep 12 '22 16:09 sonarqubecloud[bot]

Won't merge due no production code

asturio avatar Jan 16 '23 10:01 asturio