Libre-TrainSim icon indicating copy to clipboard operation
Libre-TrainSim copied to clipboard

Fix: prepend file schema to open content folder path on macOS

Open alopix opened this issue 1 year ago • 4 comments

Resolves #552

Prepending file schema to open content folder path. This will still work on Windows and other OSs. If someone can check if always prepending "file://" also works on other platforms there would not be the need for this kind of workaround.

alopix avatar Feb 26 '24 09:02 alopix

Works on Linux as well :+1:. Can someone please test it on Windows

Jomosoto avatar Feb 28 '24 00:02 Jomosoto

@Jomosoto would you mind testing this branch on Linux as well: https://github.com/alopix/Libre-TrainSim/tree/552-macos-open-content-folder-fix-alternative It prepends file:// all the time instead of checking for OS. I am wondering if this is handled automatically by godot or if there really needs an OS check

alopix avatar Feb 28 '24 09:02 alopix

Yes, that's what I tested. Sorry forgot to mention

Jomosoto avatar Feb 28 '24 12:02 Jomosoto

Ah cool, thanks that is brilliant. Once there is a Windows confirmation I can change this PR to the simple code then

alopix avatar Feb 28 '24 13:02 alopix

I’ve pushed the simpler changes into the branch 👍

alopix avatar Mar 12 '24 08:03 alopix

Thank you for the patience and congratulations for your first merged contribution 🎉

HaSa1002 avatar Mar 15 '24 07:03 HaSa1002

Also thanks @Jomosoto for the review and merge. I have no clue how to merge with the mobile app xD

HaSa1002 avatar Mar 15 '24 07:03 HaSa1002