xapi-service icon indicating copy to clipboard operation
xapi-service copied to clipboard

refactor(deleteActivityProfile): Restructuring

Open ryasmi opened this issue 5 years ago • 4 comments

ryasmi avatar Dec 13 '20 16:12 ryasmi

This pull request fixes 1 alert when merging 789722954a51457ad85db568b7389de0262218ff into 22803df66a2b2a3fa4a1d90070a3a28c837e7914 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

lgtm-com[bot] avatar Dec 14 '20 16:12 lgtm-com[bot]

This pull request fixes 1 alert when merging 26d8e30fd3b556141adbcd239b5101cce10af24e into 47f7548ccc5f106a1a41eaaaf8352db36bce576a - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

lgtm-com[bot] avatar Mar 10 '21 10:03 lgtm-com[bot]

This pull request fixes 1 alert when merging a4b021604851309a0737df3a0e7666ecd7614d16 into 47f7548ccc5f106a1a41eaaaf8352db36bce576a - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

lgtm-com[bot] avatar Mar 10 '21 14:03 lgtm-com[bot]

Codecov Report

Merging #719 (a4b0216) into master (47f7548) will decrease coverage by 1.39%. The diff coverage is 71.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #719      +/-   ##
==========================================
- Coverage   99.23%   97.83%   -1.40%     
==========================================
  Files         602      631      +29     
  Lines        6235     6559     +324     
  Branches      456      494      +38     
==========================================
+ Hits         6187     6417     +230     
- Misses         11       88      +77     
- Partials       37       54      +17     
Impacted Files Coverage Δ
...ActivityProfile/tests/utils/assertOutsideClient.ts 100.00% <ø> (ø)
...rofile/utils/getClient/getClientRecordFromMongo.ts 20.00% <20.00%> (ø)
...ns/deleteActivityProfile/utils/translateWarning.ts 43.47% <43.47%> (ø)
...eleteActivityProfile/utils/createExpressHandler.ts 58.97% <58.97%> (ø)
...tivityProfile/utils/getAuthConfig/getAuthConfig.ts 66.66% <66.66%> (ø)
...ctivityProfile/utils/getClient/trackClientUsage.ts 71.42% <71.42%> (ø)
.../deleteActivityProfile/utils/handleErrorViaHttp.ts 71.87% <71.87%> (ø)
...file/utils/getClient/getClientRecordFromTesters.ts 73.33% <73.33%> (ø)
...ActivityProfile/utils/getClient/getClientRecord.ts 75.00% <75.00%> (ø)
...deleteActivityProfile/utils/getClient/getClient.ts 80.00% <80.00%> (ø)
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 47f7548...a4b0216. Read the comment docs.

codecov[bot] avatar Mar 10 '21 14:03 codecov[bot]