Mannequin icon indicating copy to clipboard operation
Mannequin copied to clipboard

Drupal 9 testing and updates

Open mrossi113 opened this issue 5 years ago • 5 comments

mrossi113 avatar Nov 11 '20 22:11 mrossi113

Looking into how to make Mannequin compatible with Drupal 9 and backward compatible with Drupal 8 versions. So are we are seeing some problems with adding Drupal 9.

Here are the issues so far:

  • We need to add Symfony ^4.0 and Twig ^2.12.0
  • We currently use silex/silex as a web framework in Mannequin.php which is at end of life and does not support Symfony 4.0
  • Some work still needs to be done to see what can be used instead of silex/silex for Mannequin and work with multiple different versions of Symfony.

mrossi113 avatar Nov 17 '20 18:11 mrossi113

We are moving the silex/silex to symfony/flex within the Mannequin project for Drupal 9 update. This way we can keep it within Symfony eco-system.

mrossi113 avatar Nov 25 '20 17:11 mrossi113

I need to update the PHPUnit's from 6 to 7 being used in this repository with Drupal 9.

mrossi113 avatar Dec 15 '20 22:12 mrossi113

Just need to fix a few of the tests now for Drupal 9 to pass. Which looks to be the same 8 test failing on both D9 versions.

mrossi113 avatar Dec 16 '20 20:12 mrossi113

Hi, I just tried to use your D9 branch. I cannot use it on D9 because of this dependency: "symfony/finder": "^2.7 ||^3.0"

I have a conflict: conflicts with symfony/dependency-injection[v4.4.20]

Changin to "symfony/finder": "^2.7 ||^3.0 || ^4.0 || ^5.0" fix the dependency issue. But how do you compile exactly? The mannequin executable is missing from bin. I've read the contributing file but I didn't get what is the procedure to package.

I found out that the package command is probably something like this: node scripts/release.js 2.0.0 --no-commit

Which is crashing for me because it is using "git st" which is not a native git command. It would be great to replace by "git status".

And then after creating my git alias, it is still crashing for me: `fs.js:160 throw new ERR_INVALID_CALLBACK(cb); ^

TypeError [ERR_INVALID_CALLBACK]: Callback must be a function. Received undefined`

Maybe I burned some steps but it is hard to figure things out by exploring the repo. I am using Node v14.15.5, what version is actually supported because it says above v6.

EDIT: Using v8.17.0 seems to pass but still no executable bin/mannequin

pjoulot avatar Apr 20 '21 11:04 pjoulot