LaserWeb4 icon indicating copy to clipboard operation
LaserWeb4 copied to clipboard

Moving onto production builds

Open jorgerobles opened this issue 8 years ago • 3 comments

I've been wondering of compiling production builds instead development ones https://facebook.github.io/react/docs/optimizing-performance.html#use-the-production-build

We have an steady build now with no critical bugs, we could do some benchmark on this side.

jorgerobles avatar May 12 '17 06:05 jorgerobles

Theres a bug at the moment somewhere in lw4 that causes npm run bundle-prod to fail

On May 12, 2017 8:39 AM, "jorgerobles" [email protected] wrote:

I've been wondering of compiling production builds instead development ones https://facebook.github.io/react/docs/optimizing- performance.html#use-the-production-build

We have an steady build now with no critical bugs, we could do some benchmark on this side.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/LaserWeb/LaserWeb4/issues/303, or mute the thread https://github.com/notifications/unsubscribe-auth/AHVr28524ozJMOztRFN9OtgwuuOP6YO3ks5r4_6EgaJpZM4NY5WX .

ghost avatar May 12 '17 06:05 ghost

then put to work! :rofl:

Ok will test on weekend :smile:

jorgerobles avatar May 12 '17 06:05 jorgerobles

I've solved bundle-prod on (bundle-prod own branch) https://github.com/LaserWeb/LaserWeb4/commit/7e670004c3e13ad558fdf8d7189d5ff27c2dde00

I haven't seen any side effects, but maybe are. Please take a look.

Also, should disable react middleware if on prod. any ideas?

jorgerobles avatar May 12 '17 15:05 jorgerobles