HoloColorPicker SaturationBar not properly picking up Value

While playing around with a setup that includes Picker, SaturationBar and ValueBar I noticed that the SaturationBar and ValueBar don't interact properly. There is always a little jump in the color when going from adjusting one bar to adjusting the other bar.

After a little digging I think I've found the problem: in the SaturationBar on line 478 it should be "mHSVColor[2]" instead of "1f"? Could someone correct this or instruct me as to how to do it myself? I am new to GitHub..

Thank you!

[EDIT] I realized that it is quite a bit more complicated and am currently working on a solution that I will gladly contribute if someone is interested.

Jul 31 '17 02:07 sikaiser

Hi @bermudaparty , I´m interested in your fix! :)

Aug 01 '17 09:08 DaXmYsT

So I have a fix now that works. It is very rough around the edges though. I had to rewrite code in many places. I would appreciate instructions on how best to share, if someone is willing to explain. Otherwise I will look it up myself.

Aug 03 '17 06:08 sikaiser

You could fork that project I think. Last changes are 2 years old. If I where you I would ask LarsWerkman if he´s willing to update the project or not.

Aug 03 '17 07:08 DaXmYsT

@bermudaparty Any updates about this? :)

Aug 07 '17 07:08 DaXmYsT

I've forked the project and uploaded my changes into there. https://github.com/bermudaparty/HoloColorPicker Hope it works like this, I didn't have time to familiarize myself with the proper way of doing it.

Aug 08 '17 08:08 sikaiser

This is all really old by now. But if anyone is still interested, I just pushed some updates to my fork (/bermudaparty/HoloColorPicker) that now make the whole thing properly operable (in my opinion).

All the bars update each other real time.
This initially caused some wobbling and innaccuracies due to conversion between HSV and RGB. -> Everything is now handled in HSV and the wobbling gone.
This brings the added advantage that it was very easy to merge Saturation- and ValueBar into one class (OmniBar) that can be told at runtime whether it should set saturation or value (the only difference is the location in the HSV array). This does not really make a difference for using the whole thing, but it greatly simplifies further development as there is one less class to maintain now.

Maybe if I get around to it I'll create a pull request, but it doesn't look like it would ever be merged. So I might not bother.

Sep 10 '18 19:09 sikaiser