Laravel-Backpack
Use local vendor directory as consistent source for elFinder assets
WHY
BEFORE - What was wrong? What was happening before this PR?
ElFinder assets were collected from multiple places, i.e. the vendor directory, a GitHub archive and a CDN.
This should be no issue, but could cause inconsitencies as versions are not necessarily matching.
AFTER - What is happening after this PR?
All ElFinder assets are retrieved from the vendor directory. This ensures consistency, removes external dependencies and allows updating/pinning the version by the user.
HOW
How did you achieve that, in technical terms?
Add a @bassetDirectory(base_path('vendor/studio-42/elfinder/'), 'elfinder-vendor') directive to have a "single source of truth" for elFinder assets. Note that the entire directory has to be copied, as some part of the elfinder script uses relative urls to fetch assets, which causes issues if only individual bassets are used.
Is it a breaking change or non-breaking change?
No.
How can we test the before & after?
Check the various implemented views to assert assets are loaded and correct.
Hey @jnoordsij Thanks for the PR.
@pxpm could you please review this? Thanks
