langstream icon indicating copy to clipboard operation
langstream copied to clipboard

mini-langstream delete fails if other minikube clusters are defined

Open Gagravarr opened this issue 2 years ago • 0 comments

The mini-langstream delete command assumes that the mini-langstream cluster is the only one defined in minikube, and tries to both a delete and a purge (removing the .minikube folder)

However, if you have multiple clusters setup, eg

minikube profile list
|-----------------|-----------|---------|--------------|------|---------|---------|-------|--------|
|     Profile     | VM Driver | Runtime |      IP      | Port | Version | Status  | Nodes | Active |
|-----------------|-----------|---------|--------------|------|---------|---------|-------|--------|
| mini-langstream | docker    | docker  | 192.168.49.2 | 8443 | v1.27.4 | Running |     1 |        |
| minikube        | docker    | docker  | 192.168.49.2 | 8443 | v1.27.4 | Unknown |     1 | *      |
|-----------------|-----------|---------|--------------|------|---------|---------|-------|--------|

Then the call to delete will fail

mini-langstream delete
Deleting minikube: 📌  Multiple minikube profiles were found - 
📌      - mini-langstream
📌      - minikube

❌  Exiting due to MK_USAGE: Usage: minikube delete --all --purge

I would suggest that the delete call should first check if there are additional clusters defined. If there are, it should only delete the mini-langstream cluster (minikube delete -p mini-langstream) and probably just warn the user that the full minikube purge wasn't done due to other clusters still remaining

Gagravarr avatar Nov 08 '23 11:11 Gagravarr