server icon indicating copy to clipboard operation
server copied to clipboard

[lua] convert Thick Shells to IF

Open Grahf0085 opened this issue 9 months ago • 1 comments

I affirm:

  • [x] I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • [x] I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • [x] I have read and understood the Contributing Guide and the Code of Conduct.
  • [x] I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Converts the quest Thick Shells to interaction framework. It also adds a reminder text from the NPC when the quest is accepted, a text from the NPC when you trade the wrong item, and a new text from the NPC after you complete the quest that replaces his default dialog.

Used this capture from @KnowOne134 https://www.youtube.com/watch?v=JeS6-kR7jNA

Steps to test these changes

!gotoid 17727552 Talk to Vounebariont and you should get default dialog....something about bad princes !setfamelevel 0 5 Talk to Vounebariont and he should get event 516 where NPC says he brews potions and needs beetle shells Should now have quest in current list Talk to NPC again to get reminder dialog about bringing 5 shells Trade him something besides beetle shells or less than 5 beetle shells to get dialog about him not asking for this !additem 889 12 to add beetle shells Trade him five or more beetle shells and he will take 5 and complete the quest Talk to him again and he should give you reminder dialog about still needing beetle shells You can trade him five more shells for gil and fame

Grahf0085 avatar May 15 '25 19:05 Grahf0085

Added issue related to this PR: https://github.com/LandSandBoat/server/issues/7573

Grahf0085 avatar May 15 '25 23:05 Grahf0085

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] avatar Sep 18 '25 02:09 github-actions[bot]