server icon indicating copy to clipboard operation
server copied to clipboard

Move auto attack damage to lua

Open overefined opened this issue 9 months ago • 0 comments

I affirm:

  • [x] I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • [x] I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • [x] I have read and understood the Contributing Guide and the Code of Conduct.
  • [x] I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Everything is conditioned on ENABLE_AUTO_ATTACK_LUA in map.lua

  • Moves damage calculations from CAttack::ProcessDamage() to lua
  • Adds lua versions of HandleStoneskin, doConsumeMana, doSoulEater
  • Adds lua binding for attackutils::CheckForDamageMultiplier

The first pull request working towards a version of https://github.com/LandSandBoat/server/pull/7461

Steps to test these changes

Observe auto attack damage under the various affected conditions.

overefined avatar Apr 27 '25 00:04 overefined