server icon indicating copy to clipboard operation
server copied to clipboard

[Magic] Apply magic-hit-rate force-fail after resistance-rank handling

Open Xaver-DaRed opened this issue 1 year ago • 0 comments

I affirm:

  • [x] I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • [x] I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • [x] I have read and understood the Contributing Guide and the Code of Conduct.
  • [x] I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Applies resistance auto fail after handling resistance rank, not before (in short, allow immunobreak effect to be applied before assuming we fail)

Steps to test these changes

Cast enfeebling spells to immunobreak a mob and see it has an actual effect on resist rate

Xaver-DaRed avatar Oct 18 '24 16:10 Xaver-DaRed