🐛 Sauromugue Champaign place's char under map

[Mortalelite]

I affirm:

• [x] I understand that if I do not agree to the following points by completing the checkboxes my issue will be ignored.
• [x] I have read and understood the Contributing Guide and the Code of Conduct.
• [x] I have searched existing issues to see if the issue has already been opened, and I have checked the commit log to see if the issue has been resolved since my server was last updated.

OS / platform the server is running (if known)

Windows

Branch affected by issue

base

Steps to reproduce

Use GM Command !zone Sauromugue Champaign and will be placed under the map

Also the lua shows the same position https://github.com/LandSandBoat/server/blob/base/scripts/zones/Sauromugue_Champaign/Zone.lua#L25

Discord Post that Shizima made https://discord.com/channels/392903136336936960/832349765718900827/1284908588309151744

Expected behavior

Not be under the map when using !zone Sauromugue Champaign

[EpicTaru]

https://github.com/LandSandBoat/server/pull/3608 looks to be the commit that changed the default coordinates for a GM chara using !zone.

Checking the above PR and using the old coordinates places a GM chara at the zone out point from Garliage Citadel.

For reference, in the zonelines.sql file, the zone out point from Port Jeuno to Sauromugue Champaign is found at https://github.com/LandSandBoat/server/blob/1b174fb2ffc2820f30920cf6c5f0153605ee485e/sql/zonelines.sql#L176 (-574.647, -0.680, 399.974, 7), which the coordinates (-571, 1, 339, 7) in the lua linked in the issue ticket is not that far off from but is just far enough out of bounds to stick a character where it currently is.

-574.647, -0.680, 399.974, 7 -- old
-571    ,  1    , 339    , 7 -- existing

I'm wondering if the above PR meant to place a GM chara at the zone out point from Port Jeuno? It's an easy enough PR to fix the coordinates in the lua to be either one but which one should it be? Thoughts anyone?

[DarkTannin]

That's a good question. Sounds like there could be valid arguments for both. My vote would go to whichever would be the smallest change, hence the one near Garlaige since it's near what the current value is.

[overefined]

This appears to be fixed.

[EpicTaru]

This appears to be fixed.

Confirmed, looks like https://github.com/LandSandBoat/server/pull/7225 back in middle of March fixed this issue. Can be closed at earliest convenience.