server icon indicating copy to clipboard operation
server copied to clipboard

[BCNM] Implement BCNM20 Shooting Fish

Open The-Aerec opened this issue 1 year ago • 3 comments

I affirm:

  • [x] I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • [x] I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • [x] I have read and understood the Contributing Guide and the Code of Conduct.
  • [x] I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Implements the Aqua Ball Mechanic for BCNM20 shooting fish.

Basis and evidence for following changes: https://youtu.be/V0Qp99O1AkA https://drive.google.com/open?id=1ZpZ9FEQ3TYeCc9lPig-y2p6pCRLNkdyF https://ffxiclopedia.fandom.com/wiki/Shooting_Fish

image

Ability 313 it is - renamed from counterspore for clarity

Steps to test these changes

Enter BCNM20 shooting fish and see the mobs properly only use their knockback aquaball as a auto-attack.

The-Aerec avatar Sep 06 '24 19:09 The-Aerec

I can't comment on the exact line, but is everything in place for this to not be considered experimental? Mob levels, mob hp, resistances, the mechanics, the loot, the entry, etc.

zach2good avatar Sep 08 '24 12:09 zach2good

The loot in the .lua is set to the exact rates of Clopedia with limited samples. Given the limited drop variance, Platoon weapons for example are more likely each an equal weight with the others in the slot. Would it make sense for the weights to be more equalized for some of these drops?

LacunaXI avatar Sep 08 '24 18:09 LacunaXI

Yes, ideally we use loot with the weights defined in xi.loot.weight. https://github.com/LandSandBoat/server/blob/base/scripts/globals/battlefield.lua#L64-L72

jmcmorris avatar Sep 09 '24 02:09 jmcmorris

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] avatar Sep 20 '25 02:09 github-actions[bot]