server icon indicating copy to clipboard operation
server copied to clipboard

[core] Fix scaling of range critical hit rate from AGI

Open TracentEden2 opened this issue 1 year ago • 0 comments

I affirm:

  • [x] I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • [x] I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • [x] I have read and understood the Contributing Guide and the Code of Conduct.
  • [x] I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

This fixes a small issue related to critical hit rate calculation from AGI. Essentially, instead of using abs(dAGI), we should be using max(0, dAGI) so that negative dAGI do not have any impact on crit hit rate (this completes the fix started in my previous PR, and thus should have been there, my apologies). Also no source that I could find denotes a known cap (unlike for dDex and critical hit rate), thus I removed the cap (see bg-wiki here).

Steps to test these changes

Fight mobs with higher AGI and lower AGI (than player) and use RAs and track critical hit rate

TracentEden2 avatar Mar 04 '24 21:03 TracentEden2