server icon indicating copy to clipboard operation
server copied to clipboard

🐛 [SMN] BP: Ward pet_skills rework does not consider the pet as a target

Open N3ckB3ard opened this issue 2 years ago • 0 comments

I affirm:

  • [x] I understand that if I do not agree to the following points by completing the checkboxes my issue will be ignored.
  • [x] I have read and understood the Contributing Guide and the Code of Conduct.
  • [x] I have searched existing issues to see if the issue has already been opened, and I have checked the commit log to see if the issue has been resolved since my server was last updated.

OS / platform the server is running (if known)

Windows 10

Branch affected by issue

base

Steps to reproduce

The initial change to converting SMN pet abilities to the new pet_skills.sql system has created a issue skipping the summoned pet as the initial target to BP Ward abilities. This issue prevents the summoned pets blood pact ability to target itself prior to the selected target. I have verified that validTargets fields are set to 3 TARGET_SELF = 0x01, TARGET_PLAYER_PARTY = 0x02 for all related BP abilities and yet the pet is not considered as the initial target or target in general. Due to this, the logic that will be implemented for SMN pets will be incorrect with the message target and will need a correction when resolved.

Expected behavior

When using a BP ability such as "Spring Water" Leviathan should be the first initial target of the message and effect. Retail display: image LSB display: image

Note: you will also notice a slight color difference between the text. Both displays are ran through the same client with only capture addon loaded. I am unsure why the text display does not match retail.

N3ckB3ard avatar Jan 15 '24 01:01 N3ckB3ard