🐛 getPartyWithTrusts() issue when using "multi-process"
I affirm:
- [x] I understand that if I do not agree to the following points by completing the checkboxes my issue will be ignored.
- [x] I have read and understood the Contributing Guide and the Code of Conduct.
- [x] I have searched existing issues to see if the issue has already been opened, and I have checked the commit log to see if the issue has been resolved since my server was last updated.
OS / platform the server is running (if known)
Windows 10
Branch affected by issue
base
Steps to reproduce
Pull LSB.
Set up "multi-process" here
Create two new players.
Set GM level 5 on player 1.
Player 1: !addalltrusts !addkeyitem RHAPSODY_IN_WHITE !addkeyitem RHAPSODY_IN_CRIMSON
Player 1: /sea all and invite Player 2 to a party
Move Player 1 to a map process with a different zone port.
Player 1 though in a party with player 2, will now be able to summon 5 trusts
Expected behavior
It seems caster:getPartyWithTrusts() is not considering other party members in a different map processes(zone port) when returning members. This is my theory based on the logic:
https://github.com/LandSandBoat/server/blob/base/scripts/globals/trust.lua#L317-L355
Using prints past Line 348
print('Party', party)
print('numPt', numPt)
print('numTrusts', numTrusts)
returned the following
This isn't a thing we're going to be able to reasonably fix until the eventual party system rewrite where we move everything onto the world server.
It's a thing we've thought about, and even planned a little bit, but it's such a huge and horrible piece of work its hard to get the motivation to do it: https://github.com/LandSandBoat/server/pull/3623