🐛 Carbuncle's Cuffs (Bonus attributes) not working
I affirm:
- [x] I understand that if I do not agree to the following points by completing the checkboxes my issue will be ignored.
- [x] I have read and understood the Contributing Guide and the Code of Conduct.
- [x] I have searched existing issues to see if the issue has already been opened, and I have checked the commit log to see if the issue has been resolved since my server was last updated.
OS / platform the server is running (if known)
Branch affected by issue
base
Steps to reproduce
Have "Carbuncle's Cuffs" equipped while having SMN or /SMN job. Cast Summoning magic: Carbuncle Use Blood Pact: Ward "Shining Ruby"
Expected behavior
The item Carbuncle's Cuffs has bonus attributes of: Summoning magic casting time - 1 Shining Ruby: Adds "Regen" effect
Both of which don't appear to be functioning.
My screenshots illustrate the "Regen" effect not functioning as I took screenshots before/after applying "Shining Ruby" and was still only receiving the +1/tic from the /whm job ability.
I'm not sure how I could capture evidence of the summoning magic casting time function with screenshots but I did try manually using a stopwatch/timer when using Summoning magic - and I wasn't getting any detectable difference.
Tiberon on the Discord has posted saying the following:
"Checked the code - I see no code attempting to apply these bonus
I've requested a capture from retail and can implement the changes as we find out how this should work.
Just googling, ive found 2 JP wiki sources, bgwiki, and regular wiki all with slight variations of how this should work.
Regen might be locked to having the gloves equipped - unequip the gloves, lose the regen. Its not clear if re-equipping brings the regen back. The duration is unknown. IF there is an icon for the effect, that is unknown. If it stacks with other regen sources (spell or drink) is unknown.
Summoning magic reduction, no idea what -1 actually means. I hope 1 second, but SE has a fun sense of humor on these."
I can attest that anything with "reduced summoning cast time" is currently not working.
This is now implemented
https://github.com/LandSandBoat/server/pull/4589