🐛 Jailer of Hope - Z Position constantly changes
I affirm:
- [x] I understand that if I do not agree to the following points by completing the checkboxes my issue will be ignored.
- [x] I have read and understood the Contributing Guide and the Code of Conduct.
- [x] I have searched existing issues to see if the issue has already been opened, and I have checked the commit log to see if the issue has been resolved since my server was last updated.
OS / platform the server is running (if known)
Windows10
Branch affected by issue
base - b40e6b5166
Mar 22 2023
Steps to reproduce
Pop Jailer of Hope Engage JoH and run to nearest land north of spawn point Watch JoH play peekaboo (Begins underwater at spawn, comes above water and attacks, returns underwater/land, lather rinse repeat) Cannot Weaponskill or hit JoH while it is hidden
Note: some attacks hit while the mob is above terrain but once it goes below terrain no attacks can hit.

As you can see in the above screenshot a few hits are able to connect to JoH but the weaponskill doesn't even register as damage or a miss.
Expected behavior
Pop Jailer of Hope Engage Jailer of Hope Mob stays above terrain and can be hit
I reverted JoH lua back to bare bones like it was a regular roaming mob and added in the phuabo family mixin and JoH acted as normally expected. I then added in the phuabo mixin to the up to date JoH lua
require("scripts/globals/mobs") mixins = { require("scripts/mixins/job_special"), require("scripts/mixins/families/phuabo") }
Reloaded the server Spawned JoH and the mob acted as expected
I'm just a knob when it comes to updating any files for the server but i'm glad i was able to get this to work properly and at least contribute something even if it is a small fix.
Fixed by https://github.com/LandSandBoat/server/pull/8067