LandSandBoat
🔨 Latent Effects that grant Pet mods
I affirm:
- [x] I understand that if I do not agree to the following points by completing the checkboxes my issue will be ignored.
- [x] I have read and understood the Contributing Guide and the Code of Conduct.
- [x] I have searched existing issues to see if the issue has already been opened, and I have checked the commit log to see if the issue has been resolved since my server was last updated.
Describe the feature
Some items have latent effects that grant pet mods. For example, Affinity Earring which provides +Attack to your pet if a party member (not including the wearer) is a Puppetmaster. Or Fidelity Earring which provides +pet Accuracy if there is a Beastmaster in the party.
To my knowledge, there is no simple way to grant these effects with the current codebase.
Ideally, there wouldn't really be a big difference between granting a pet mod and granting a standard mod, but the codebase already separates item_mods and item_mods_pet. That said, I think adding two columns to item_latents for isPetMod and petType would be preferable to adding a new table for item_latents_pet.
there was a past discussion for this https://github.com/LandSandBoat/server/discussions/2672#discussioncomment-3588049 you should take a look at.
the short of it is if going extra columns instead of extra tables, I'd want to see the same with mods. I don't like the inconsistency of doing things 2 ways, and thats why the suggested table was the shortest point a to point b for that problem.
Ah, I searched issues but not Discussions. My mistake.
I actually think item pet mods should also be in the same table as item mods, but obviously that's work someone has to do.
Ah, I searched issues but not Discussions. My mistake.
I actually think item pet mods should also be in the same table as item mods, but obviously that's work someone has to do.
I kinda agree with you, but its a larger effort to do one table for each of mods and latents, rather than 4 tables.
