server icon indicating copy to clipboard operation
server copied to clipboard

Ronfaure Region NM Audit

Open CriticalXI opened this issue 3 years ago • 4 comments

I affirm:

  • [x] I have paid attention to this example and will edit again if need be to not break the formatting, or I will be ignored
  • [x] I have read and understood the Contributing Guide
  • [x] I've tested my code and the things my code has changed since the last commit in the PR, and will test after any later commits

What does this pull request do?

  • Cemetery Cherry now has server reset persistence and has been reworked to be more in line with retail.
  • Ankou, Mane, and Shii will now spawn only at night.
  • Placeholders corrected for several NMs.
  • Corrected HP, level and immunities for several NMs.
  • Edited all drop lists to utilize the TH variables and correct drop rates according to FFXIDB.
  • Edited all lottery NMs with a random respawn range to instead have a minimum respawn.

Steps to test these changes

CriticalXI avatar Jun 27 '22 23:06 CriticalXI

Is the Cemetery Cherry server reset persistence something that is confirmed in retail?

Xaver-DaRed avatar Jun 28 '22 00:06 Xaver-DaRed

@CriticalXI

server reset persistence

We devoted a module to handling that for servers that want that for these long timer NMs.

@Xaver-DaRed

Is the Cemetery Cherry server reset persistence something that is confirmed in retail?

It's not. Retail doesn't persist the state/time of deaths between maintenances. Retail also doesn't go down as often as a private server though, which is why the module.

TeoTwawki avatar Jun 28 '22 01:06 TeoTwawki

Never thought about this, too used to developing for Wings where we put all this in since it was all for the private server. I'll remove that.

CriticalXI avatar Jun 28 '22 03:06 CriticalXI

This should be good to go other than any issues you may find with my code.

CriticalXI avatar Jul 01 '22 00:07 CriticalXI

Needs a rebase, then it's just waiting for eyes other than mine.

TeoTwawki avatar Sep 08 '22 03:09 TeoTwawki

Rebased this one, hopefully good to go now.

CriticalXI avatar Sep 25 '22 06:09 CriticalXI