LandSandBoat
🐛 RDM Refresh Overwrites FoV Refresh
- [x] I have paid attention to this example and will edit again if need be to not break the formatting, or I will be ignored
- [x] I have searched existing issues to see if the issue has already been opened, and I have checked the commit log to see if the issue has been resolved since my server was last updated
- [x] I have read and understood the Contributing Guide
Branch affected by issue
base
Steps to reproduce
- Change to RDM or /RDM lv 41+
- Travel to a Field Manual
- Activate the manual, choose field support, and then choose and apply the refresh buff
- Note that you obtained a 60min duration refresh buff
- Cast RDM's "Refresh" spell on yourself
- Note that RDM's refresh overwrote the FoV refresh and now you only have one refresh buff that lasts 2.5mins
NOTEWORTHY: According to ffxiclopedia, the FoV refresh should not be overwritten by other forms of refresh. BGWiki is silent on this topic. I cannot confirm if the same symptom is true for Refresh II.
Expected behavior
Refresh 1: In step 6 the spell produces no effect and the player retains the FoV refresh. Refresh 2: Refresh 2 would overwrite FoV refresh, though. Sublimation: Sublimation would also overwrite FoV refresh.
The player gains a second form of refresh and is left with one expiring in 60mins and another expiring in 2.5mins.
Nope.
Used to overwrite. Now, the equal effect fails to land. A more powerful effect will overwrite. No idea when that update hit but it's never stacked them ever.
Screenshots:
This is slightly tricky but not too difficult to fix. right now, the effect flag tells it to 0 which is overwrite if equal or higher. To prevent refresh from overwrite book refresh it would need set to 1 which is overwrite if higher BUT the spell itself does cause it to overwrite itself, and there may possibly be drink items that would apply - I'd need to check. To get around that, the tier field could be used or we could do some manual silent removal script side when ion the line right before the new equal power effect would land.
I will leave it to some enterprising contributor to pull request, because while it can be annoying for the player this isn't a high priority.
If a server would like to take the non-retail road and make them stack, the script side could setFlag on the effect its applying to allow duplicates. (see pup maneuvers, atma, and runes) setting allow duplicates flag in the sql would likely lead to all refresh forms stacking for some very abusable super infinity MP.
@TeoTwawki Thank you for your retail clarifications. In that case, I misread ffxiclopedia. What they documented is in line with your findings now that I'm no longer assuming that they stack (they never mention stacking, only overwriting).
Can you please confirm in retail if SCH's sublimation overwrites it as well? I don't have an active retail account, sorry.
@TeoTwawki Thank you for your retail clarifications. Can you please confirm if SCH's sublimation overwrites it as well?
I don't have sch to test with unfortunately but I expect it to act the same way it does with a normal refresh of the same potency as the book refresh. (retail decides things by power level normally)
Since ffxiclopedia was right on the overwriting aspect (I just read them wrong) it may be worth investigating if they are right about sublimation as well.
@TeoTwawki Thank you for your retail clarifications. In that case, I misread ffxiclopedia. What they documented is in line with your findings now that I'm no longer assuming that they stack (they never mention stacking, only overwriting).
it's more their description is too broad. other sources do overwrite it but only if more potent.
Can confirm on retail that Sublimation overwrites FoV Refresh. I think technically it's got more MP per tick than Refresh 1 does, so probably coded as a higher power level.
Can confirm on retail that Sublimation overwrites FoV Refresh. I think technically it's got more MP per tick than Refresh 1 does, so probably coded as a higher power level. !
Thanks! By the way, have we considered using the Windower Witness Protection addon for these screenshots? It garbles player names so that neither the player nor their server can be identified. It'd cut back on the good details that get hidden by the black-boxing and might also make your process itself easier since you wouldn't have to black-box. I'm guessing that it is known about but just not sufficient for our purposes, though. Just thought I'd mention it, just in case.
Can confirm on retail that Sublimation overwrites FoV Refresh. I think technically it's got more MP per tick than Refresh 1 does, so probably coded as a higher power level,
Thanks for the checking and screens @Sunderous !
Can confirm on retail that Sublimation overwrites FoV Refresh. I think technically it's got more MP per tick than Refresh 1 does, so probably coded as a higher power level. !
Thanks! By the way, have we considered using the Windower Witness Protection addon for these screenshots? It garbles player names so that neither the player nor their server can be identified. It'd cut back on the good details that get hidden by the black-boxing and might also make your process itself easier since you wouldn't have to black-box. I'm guessing that it is known about but just not sufficient for our purposes, though. Just thought I'd mention it, just in case.
I actually totally forgot about that addon, I randomly heard about it a few weeks ago. I'll try it out next time because that is definitely a good use-case outside streaming.
Field Support = 1mp/tick I have been testing on private. From checking online this is still how much on retail? If so need to look a bit closer on how to get this not to overwrite with 3mp/tick ...
I guess we may need to use TIER instead of POWER then. it's in the same enumeration