Party Treasure Pool / Loot Window Display Variance

[DarkTannin]

• [x] I have paid attention to this example and will edit again if need be to not break the formatting, or I will be ignored
• [x] I have searched existing issues to see if the issue has already been opened
• [x] I have checked the commit log to see if the issue has been resolved since my server was last updated
• [x] I have read the Contributing Guide
• [x] I have specified what branch this happens on branch: base

Additional Information (Steps to reproduce/Expected behavior) :

Persistent issue with Party Treasure Pool / Loot window displaying differently for multiple players in the same party. Some players see the standard treasure pool window, while others see the expanded treasure pool window that is only supposed to show up while in Dynamis. This problem occurs in any and all zones, both in and out of Dynamis. Tested multiple characters on multiple computers and issue seems to always follow the same character(s).

Character 1 - Normal Treasure Pool

Character 2 - Dynamis Treasure Pool

Happy to provide any additional screenshots, logs, etc to help in diagnosing and addressing this issue.

[zach2good]

It was recently figured out that there's a flag that controls which of these pools you see sent in some packets. I believe it's stuff in:

byte 0x20 in packet 0x0D
byte 0x29 in packet 0x37

We currently have some overlap with other character flags, so 'small' characters will get the Dyna treasure pool more often.

It also has an effect over if local mobs being fought by others turn up as purple or red.

[MowFord]

As Teo mentioned, https://github.com/LandSandBoat/server/pull/4922 is related but based on my knowledge of this subject I think will fully resolve the issue in this direction.

If LSB ever decides to move forward with giving a core option to enable the zone-wide pool then there's also a packet to be set in CCharPacket::updateWith. In particular, setting ref<uint8>(0x20) |= 0x08; will push the update (as mentioned by zach above)