lnreader icon indicating copy to clipboard operation
lnreader copied to clipboard

Legacy Backup is not working

Open Pheonix-Flames opened this issue 1 year ago • 1 comments

Steps to reproduce

Go to More > Settings > Backup > Create Backup Try to create a backup

Expected behavior

It should create a backup in the selected location

Actual behavior

It is not creating a backup and there is an error poping up Screenshot_2024-10-12-20-55-06-63_3c1c179116822eec69c21805387f0489

LNReader version

2.0.0

Android version

Android 11

Device

Realms 3 Pro

Other details

Please solve this issue I have to transfer my Data to other phone

Acknowledgements

  • [X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
  • [X] I have written a short but informative title.
  • [X] If this is an issue with a source, I should be opening an issue in the sources repository.
  • [X] I have updated the app to version 2.0.0.
  • [X] I will fill out all of the requested information in this form.

Pheonix-Flames avatar Oct 12 '24 17:10 Pheonix-Flames

Delete the folder and try again

nyagami avatar Oct 17 '24 06:10 nyagami

Delete the folder and try again

Tried this on Droid 12. Same error msg, I believe. I've even tried clearing access under Storage & cache and starting over. I've tried creating new folders in Download and elsewhere. Nothing seems to work. Even my Google backup won't complete and will crash the app. :-(

buthub avatar Apr 12 '25 23:04 buthub

Delete the folder and try again

Any Updates on this problem ?

Pheonix-Flames avatar May 25 '25 07:05 Pheonix-Flames

I've implemented a solution by replacing the current hack of "select a folder for full write permissions and then copy into it" (which evidently doesn't work anymore) with a proper file export intent using @react-native-documents/picker.

Compatibility issue: The library is cross-platform, but the URI handling is probably different on iOS and I can't test it.

I also essentially rewrote the entire legacy logic to replicate what the "Self-Hosted" backup does, except instead of uploading two zip files, I just combine them into one and export it (for now just as a zip file, but calling it something like .lnrbak could be a good idea).

Note that I've simply copied the logic of self-hosted backups exactly; I have not fixed any existing bugs in that logic, some of which I've noticed and will look into further. Both (or all three) backup types use the same utility methods, so their functionality and correctness is now DRYly coupled.

Since this is such a fundamentally basic feature, I believe writing it off as "legacy" is really bad, and it'd be good if that wording could be removed in the translation strings. "Local Backup" is more descriptive.

ilonachan avatar Oct 15 '25 17:10 ilonachan

Note that I've simply copied the logic of self-hosted backups exactly; I have not fixed any existing bugs in that logic, some of which I've noticed and will look into further. Both (or all three) backup types use the same utility methods, so their functionality and correctness is now DRYly coupled.

Silver you mentioned self-hosted backups, are there any instructions available?

ovizii avatar Nov 11 '25 17:11 ovizii