lmms icon indicating copy to clipboard operation
lmms copied to clipboard

Add Horizontal Scroll Bar to the File Browser

Open AW1534 opened this issue 8 months ago • 9 comments

image

fixes #7879

AW1534 avatar May 29 '25 23:05 AW1534

Inviting @Gabrielxd195 to test this at https://lmms.io/download/pull-request/7913

AW1534 avatar May 29 '25 23:05 AW1534

I tested it, and it seems to work! The scrolling feels a little sensitive to me

regulus79 avatar May 30 '25 02:05 regulus79

@AW1534 That's neat, it does its job, and files located in long paths will now be visible. The only problem (not so serious) is that the bar doesn't automatically advance as you open folders. You can resize the search bar, but it's more a matter of convenience, since it's very common to navigate with the arrow keys.

Try it, navigate only with the arrow keys without resizing the search bar, and you'll see that when you want to centralize the files, pressing the "down" key to continue browsing will return the bar to the beginning and not stay in the center or where you left it.

https://github.com/user-attachments/assets/70fe9248-4747-4298-8bb5-ab880bd3a3a8

Gabrielxd195 avatar May 30 '25 06:05 Gabrielxd195

@Gabrielxd195 also goes at the start when click down

firiox avatar May 30 '25 21:05 firiox

@AW1534 how difficult would it be to resolve the issue @Gabrielxd195 mentioned? I am also okay with moving forward with the PR and fixing it later, up to you.

sakertooth avatar Jun 14 '25 00:06 sakertooth

@AW1534 Personally, I would have liked them to fix this bug even if it took them more time, because LMMS is riddled with small, accumulated bugs that make it look unstable. And since there are more important things than this simple problem, if they merge this without fixing this small bug and leave it for another PR, I don't think they'll fix it immediately. Now, if nothing can be done, then merge this PR, but please make another PR so that the implemented feature doesn't look incomplete.

Gabrielxd195 avatar Jun 14 '25 06:06 Gabrielxd195

@firiox That's right, when you press the down key, the bar returns to the top, and that's very annoying.

Gabrielxd195 avatar Jun 14 '25 06:06 Gabrielxd195

@AW1534 how difficult would it be to resolve the issue @Gabrielxd195 mentioned? I am also okay with moving forward with the PR and fixing it later, up to you.

I'd assume it's not too difficult, I haven't looked into it. I just haven't had much time at all to code lately. I'll look into it this weekend if I get the chance.

AW1534 avatar Jun 14 '25 07:06 AW1534

The scroll bar also jumps back to the left when an item is clicked. If there's no built in option for this, I suppose you could wrap the whole tree view in a separate QScrollArea and somehow connect to QHeaderView::sectionResized to update the size. Feels complicated though.

allejok96 avatar Jun 14 '25 22:06 allejok96