lmms icon indicating copy to clipboard operation
lmms copied to clipboard

Fit the piano to the window size.

Open Gabrielxd195 opened this issue 1 year ago • 2 comments

Enhancement Summary

SlicerT is now resizable and some LV2 instruments have different sizes. I think it would be better if the piano notes of the instruments would adapt to the size of the instrument window. This way it would look nicer and more aesthetic.

Implementation Details / Mockup

Before Boto de maximizar en los instrumentos

After Extirar piano en los instrumentos The stretched piano image is just a mockup made in Gimp, which makes it look a bit disproportionate, the wish is not for it to look disproportionate but for it to adapt to the size of the window while keeping the proper proportions.

Please search the issue tracker for existing feature requests before submitting your own.

  • [X] I have searched all existing issues and confirmed that this is not a duplicate.

Gabrielxd195 avatar Sep 19 '24 21:09 Gabrielxd195

Translate the first message pls.

Rossmaxx avatar Sep 20 '24 04:09 Rossmaxx

@Rossmaxx OMG!!!. I made this report in such a hurry that I didn't notice that I had posted it in Spanish. Sorry.

Gabrielxd195 avatar Sep 20 '24 06:09 Gabrielxd195

I made a similar PR to center the piano #7731. With a bit more work I could probably make it so that it expands, but I feel like there could also be some potential problems, like if you resize the instrument a whole lot, the piano keys could get very wide. Maybe that's fine? Also we would probably want a minimum width, since I assume we don't want the normal sized instruments to have their whole keyboards squished into the visible portion of the window.

EDIT: Oh I didn't realize this issue was made in september, way before I made that pr.

regulus79 avatar Mar 03 '25 23:03 regulus79