lmms icon indicating copy to clipboard operation
lmms copied to clipboard
verified publisher icon LMMS

Adds Item Starring and other FileBrowser changes

Open AW1534 opened this issue 1 year ago • 2 comments

Item Starring

Added the ability to star items. This gets added to its own tab named "Starred Items". note that this required a minor config change. I'm unsure whether this counts as a new config version.

Minor Changes:

  • Instead of just saying "Open containing folder" in the context menu it now says "Show file in [File Explorer / Finder / file manager]" depending on OS. You can now also open folders by right clicking them too.
  • Added File highlighting when displaying a file from the mentioned option. Aside from Windows and Mac, this works on: nautilus, dolphin, thunar, pcmanfm, nemo, caja, io.elementary.files, spacefm, pcmanfm-qt and any other file manager that supports the --select cli option can easilly be added. note that this falls back to the old system if a compatible file manager can't be found.

I am very sorry about the huge diff. at some point my IDE decided to use the .clang-format to reformat everything without me noticing.

This has been tested on Linux (manjaro, gnome) only. I will test Windows soon.

I have tried to add screen recordings but for some reason my screen recording software isn't working. I will edit this with recordings when I can

AW1534 avatar Aug 02 '24 18:08 AW1534

I haven't built and tested this branch yet but the PR is a bit messy. It looks like your master wasn't up to date with lmms/master when you coded this. Instead it's based on an earlier PR that already got merged but that was squashed down to one commit. This one: https://github.com/LMMS/lmms/pull/7309/commits It's a good idea to not issue PR's directly from your master but to do all work on separate branches.

zonkmachine avatar Aug 11 '24 13:08 zonkmachine

I haven't built and tested this branch yet but the PR is a bit messy. It looks like your master wasn't up to date with lmms/master when you coded this. Instead it's based on an earlier PR that already got merged but that was squashed down to one commit. This one: https://github.com/LMMS/lmms/pull/7309/commits It's a good idea to not issue PR's directly from your master but to do all work on separate branches.

Yeah i know. I spent ages trying to fix it and put it into It's own branch but couldnt figure out a way to.

AW1534 avatar Aug 11 '24 21:08 AW1534