lmms icon indicating copy to clipboard operation
lmms copied to clipboard

adding pattern editor subwindow horizontal scaling

Open szeli1 opened this issue 1 year ago • 5 comments

closes #7313

Made constants in TrackView static, replaced the configmanager "compacttrackbuttons" with static functions in TrackView.

Modified TrackContainerView::scrollArea to have the ability to scroll horizontally. Changed TrackContainerView::realignTracks to clamp at a minimum size.

Please review carefully. (especially the TrackView static changes)

szeli1 avatar Jul 30 '24 20:07 szeli1

You did an amazing job. Thank you

ghost avatar Aug 05 '24 18:08 ghost

This is great, now the BB editor will be better used. Do you think this can also be applied to File Explorer in the future? Because you need it.

Gabrielxd195 avatar Aug 21 '24 01:08 Gabrielxd195

Do you think this can also be applied to File Explorer in the future?

You could make a feature request about it and see if somebody implements it.

szeli1 avatar Aug 21 '24 18:08 szeli1

@szeli1 I proposed horizontal sliding in the file browser along with another improvement in #4599 but since I didn't know anything about Github at that time they closed the issue for me for having made two suggestions in the same issue and everything was left there, no one has talked about this, I think I should have suggested different matters.

Gabrielxd195 avatar Aug 21 '24 22:08 Gabrielxd195

they closed the issue for me for having made two suggestions

The closed it because one suggestion was the same as an older one. You are right about you shouldn't make an issue about 2 things. You definitely should open new issues if you have feature requests / know about bugs, but make sure nobody suggested your suggestion before.

szeli1 avatar Aug 22 '24 08:08 szeli1

To me it doesn't feel right that the TrackViews move as you scroll. Also, when you have added a lot of steps, the minimum width of the squares makes them no longer square. And you can't zoom to change the view size like in the song editor. Screenshot From 2024-12-30 11-26-00

regulus79 avatar Dec 30 '24 16:12 regulus79

Also, have you resolved @regulus79's concerns @szeli1?

sakertooth avatar Dec 30 '24 22:12 sakertooth

closing because of this:

To me it doesn't feel right that the TrackViews move as you scroll.

This requires refactoring 2 + 1 editors

szeli1 avatar Feb 27 '25 17:02 szeli1