lmms icon indicating copy to clipboard operation
lmms copied to clipboard

enable envelopes to effect chords

Open szeli1 opened this issue 1 year ago • 7 comments

This pull request adds a new button in the instrument sound shaping menu that makes the envelope apply on a chord instead of single notes. For example this can be useful when the arpeggio is turned on and the user wants to make the chord notes fade out gradually.

mentioned in #7025.

picture:

Finished15

szeli1 avatar Jun 08 '24 14:06 szeli1

Screen recording pls?

Rossmaxx avatar Jun 08 '24 14:06 Rossmaxx

Screen recording pls?

Added picture in my first comment. The arpeggio and the new button should be enabled for this to work.

szeli1 avatar Jun 08 '24 15:06 szeli1

The lcd button could get a label tho.

Rossmaxx avatar Jun 08 '24 15:06 Rossmaxx

Or i have another idea, what about adding an "arp" option similar to volume, reso, cutoff in the target tab? Wouldn't that be a better implementation?

Rossmaxx avatar Jun 08 '24 15:06 Rossmaxx

The lcd button could get a label tho.

Tested, the description does not fit. It has a SimpleTextFloat description instead.

szeli1 avatar Jun 08 '24 15:06 szeli1

Or i have another idea, what about adding an "arp" option similar to volume, reso, cutoff in the target tab? Wouldn't that be a better implementation?

I think it does not work that way. This feature can work separately for each envelope type. To my understanding the gui is not setup in a way where it would show a new menu instead of the envelope settings. This would be difficult to implement. I can try implementing it if you want.

szeli1 avatar Jun 08 '24 15:06 szeli1

If it's too difficult, better to pass on it. I would recommend you ask opinion from @Spekular who most often has a good opinion on the UX side of things.

Rossmaxx avatar Jun 08 '24 15:06 Rossmaxx

This PR will be closed, because I think a better solution would be to add a new type of controller that detects what keys are pressed and controls AutomatableModels based on that.

szeli1 avatar Dec 01 '24 19:12 szeli1