lmms icon indicating copy to clipboard operation
lmms copied to clipboard

Add support for "factorysample:" prefix

Open michaelgregorius opened this issue 1 year ago • 2 comments

Add support to upgrade files with src tags that are prefixed with factorysample:.

Fix the problem for projects that still have "bassloopes" in their source files.

See #7186 for more details.

michaelgregorius avatar May 01 '24 19:05 michaelgregorius

@michaelgregorius You often do very explanative commit messages, which is very valuable. However, some of the commits in your PRs have long commit messages without newlines. gitk does not break them down, making them hard to read. This is why e.g. vim suggests to break lines at 80 chars (or even earlier). Is it OK if you go through the commit messages of your open PRs?

JohannesLorenz avatar May 10 '24 21:05 JohannesLorenz

@JohannesLorenz, a while ago I always made sure that my commit messages all had line breaks at around 74 characters. However, this makes it rather tedious to write commit messages depending on which editor is used, especially if text is changed a lot during writing.

I am now of the opinion that it's rather a problem of the tools that display commit messages and that these tools should not make me jump through hoops just because some of them are inadequate to display the messages. The long lines are just different paragraphs when looked at with other tools.

michaelgregorius avatar May 11 '24 08:05 michaelgregorius

I don't know why this was stuck in the back burner for this long. The fixes doesn't look too bad either and people had confirmed the fix. I haven't tested it tho so would be better if someone who actually test give the opinion on it. Let's get done with the small PRs please.

Rossmaxx avatar Jun 14 '24 13:06 Rossmaxx

I have now merged this. It should be rather safe as it "only" upgrades files that are loaded but should have no effect on files that are written. So, if we found that the merge has led to problems then we should be able to revert it without causing more havoc.

michaelgregorius avatar Jun 14 '24 14:06 michaelgregorius