lmms icon indicating copy to clipboard operation
lmms copied to clipboard

Make the steps in the Pattern Editor scalable

Open michaelgregorius opened this issue 1 year ago • 4 comments

This pull request makes the steps in the Pattern Editor scalable and renders them with SVGs instead of PNGs. That way they look more "crisp" than with the current bitmap based implementation.

Here's a pattern with the changes in this pull request (click images to view in full size):

BnBRe-FinalWideCropped

Here's how the same pattern looks without the changes, i.e. in master:

BnBRe-MasterWideCropped

This fixes #3683.

michaelgregorius avatar Mar 28 '24 22:03 michaelgregorius

Error loading icon pixmap "step_btn_on_0": Datei nicht gefunden Error loading icon pixmap "step_btn_on_200": Datei nicht gefunden Error loading icon pixmap "step_btn_off": Datei nicht gefunden Error loading icon pixmap "step_btn_off_light": Datei nicht gefunden Bildschirmfoto vom 2024-04-21 01-19-01

update:

I copied the 4 files manually to /usr/local/share/lmms/themes/default/. If I now change the size, I can no longer change the velocity with the mouse wheel. If I reset it to the original size, it works again.

Z3R0C avatar Apr 20 '24 23:04 Z3R0C

@Z3R0C, the mouse wheel functionality is reinstated with commit 0959b6d2b1e which removes some duplicated code and ensures that the mouse and wheel events determine the steps in the same way.

Commit eb8017339e8 fixes the problem with the SVGs in the theme folders not being installed.

Can you please check again?

michaelgregorius avatar Apr 21 '24 09:04 michaelgregorius

Now everything works fine. Nearly. There is another problem.

https://github.com/LMMS/lmms/assets/32363130/1134b9e0-5df8-46bf-90b2-1271517e261e

https://github.com/LMMS/lmms/assets/32363130/3e2eda59-c4e5-4bc0-b389-abb81b472ecc

Z3R0C avatar Apr 21 '24 23:04 Z3R0C

Thanks for testing @Z3R0C! I was able to reproduce a weird rendering bug:

3683-WeirdRenderBug

It seems like some of the elements are rendered scaled with the correct height and some are not. I'll have to check...

michaelgregorius avatar Apr 22 '24 14:04 michaelgregorius