lmms Knob label fixes, take three

Yet another iteration of this PR after #5872 and #6651. Fixing some issues with knob tooltips and units. Edit: Added the ability to set absolute vs relative (dB / dBFS) display per control.

Dec 31 '23 17:12 zynskeywolf

looks like you might need a take four

May 06 '24 10:05 Rossmaxx

Honestly I don't think I'll have the energy to redo the same stuff over and over, hoping that one of them would eventually get merged in time.

May 06 '24 11:05 zynskeywolf

Fixed this for you (not sure why I needed to do it twice). ~I'm a bit confused on why we need the volume knob type. Shouldn't gain knobs just be using dB and not dBFS?~

Nevermind, I found @LostRobotMusic's explanation on the matter, though I think it should be implemented better. I would make a new VolumeKnob class that inherits from Knob, move the volume knob type functionality in there, and then override displayValue in VolumeKnob to display either dB or dBFS accordingly and automatically based on the volume knob type. That way it will only apply for knobs that fit the criteria of representing volume and remove the possibility of setVolKnobType being called for non-volume based knobs (e.g., start and end knobs in AFP), which is confusing design. I don't like adding it directly in FloatModelEditorBase because not all knobs are volume knobs.

May 08 '24 01:05 sakertooth