lmms icon indicating copy to clipboard operation
lmms copied to clipboard

Ripple delete the notations in piano editor

Open anytizer opened this issue 3 years ago • 8 comments

Enhancement Summary

To ripple delete notations; shifting all notes from right to left at the point of deletion.

Justification

  1. It may be useful to delete the some of the notes in between, but without leaving the gap in the notations.
  2. May be a keyboard shortcut has to be implemented to make a difference between regular delete and ripple delete.

image

In the picture, I want to delete the notes between first G4 to next G4 (selected with blue color). All note notes on the right would then shift towards left by 3 bars; resulting no gap.

anytizer avatar Aug 21 '22 21:08 anytizer

I would propose shift + delete as the shortcut (in piano roll), and that this be implemented in the song editor as well (might need a different shortcut, or it could be in the context menu).

This should just be a matter of finding all notes that start at or after the end of the selection, and shifting them left by the length of the selection (start of leftmost note to end of rightmost note), so I'll mark it as a good first issue.

Spekular avatar Aug 21 '22 21:08 Spekular

Possibly the "opposite" way of bulldozer feature #6497.

anytizer avatar Aug 23 '22 00:08 anytizer

Possibly just backspace or shift-backspace? Since it's more associated with moving everything else back by as much as is deleted...

Monospace-V avatar Aug 24 '22 14:08 Monospace-V

I was thinking shift since that's used for proportional resize, but I forgot that you need to hold control for that to move following notes. Perhaps shift+ctrl+delete would be appropriate then, which would avoid clashing with shift+delete for removing bars in the song editor.

Spekular avatar Aug 24 '22 14:08 Spekular

Wouldn't shift delete be perfect since you're essentially doing what remove bar does (plus removing the selected notes)?

I know we're talking piano roll now, but if it turns out it clashes so badly with song editor, I'd say drop the shortkey for insert/remove bar, since we have a button for it, it's not something you frequently do and especially remove bar has quite an unpolished behavior.

allejok96 avatar Aug 25 '22 19:08 allejok96

Since it seems like this issue was not yet resolved, I am going to try and work on this issue (as a first issue) :)

hberg137 avatar Apr 05 '23 00:04 hberg137

I completed work on this and just made a pull request for this issue! #6692 Just to note, I used shift + delete as the shortcut for this.

hberg137 avatar Apr 18 '23 17:04 hberg137

would propose to implement shift + delete keyboard shortcut for ripple delete. Anyone still working on this... would like to help him as a newbie.

Kartik-1311 avatar Feb 02 '24 16:02 Kartik-1311