lmms icon indicating copy to clipboard operation
lmms copied to clipboard

Loading mdaPiano causes audio spike

Open Spekular opened this issue 4 years ago • 10 comments

Steps to reproduce

  • Open new project
  • Add VeSTige
  • Load mdaPiano via browser

Master fader briefly hits red, as opposed to the expected complete silence. By itself this sounds like a click at worst, silence at best. Depending on the effects it runs through it can become loud and sustained (I accidentally ran it through Ambience reverb, which was very unpleasant).

Affected LMMS versions

1.2 and 1.3 alpha.

Spekular avatar Sep 14 '21 19:09 Spekular

I think this could be an issue with the mda vst. We fixed issues with mda piano in the lv2 version.

zonkmachine avatar Sep 14 '21 19:09 zonkmachine

I get a similar issue with Flygel. This also happens whenever you load a project with the VST in it. The more the instances of a VST causing this issue, the louder the click. This is prevented by muting the VSTs.

Monospace-V avatar Sep 15 '21 02:09 Monospace-V

@Spekular @Monospace-V You can try and add a waveshaper as first effect and just engage the Clip input button.

zonkmachine avatar Sep 15 '21 11:09 zonkmachine

Adding waveshaper and enabling clip input doesn't do anything, except perhaps reduce the volume of the click a bit. Extra note: Flygel has a very low audio spike upon loading, but when opening a project with Flygel there is a louder one.

Monospace-V avatar Sep 15 '21 13:09 Monospace-V

except perhaps reduce the volume a bit.

This is what I hoped for. Turn down the volume on your amp and see what the difference is with a reverb unit after the Waveshaper. It should get really loud without some clipping (toggle off) in there.

zonkmachine avatar Sep 15 '21 13:09 zonkmachine

That is what happens, yes. It gets insanely loud. (With the clipping enabled, it's still white noise, and still very obviously there, but doesn't spike to as loud as with clipping disabled.)

Monospace-V avatar Sep 15 '21 14:09 Monospace-V

Here is a fix for the lv2 version that looks like it could be related. https://gitlab.com/drobilla/mda-lv2/-/commit/c2d51675287343c9006256397ae50709ed2cc892 I don't think anyone push fixes upstream to the mda sourceforge page as it seem to be mostly unmaintained.

zonkmachine avatar Sep 16 '21 01:09 zonkmachine

Then is it unlikely the bug ever get fixed? (Also, because there are probably more VSTs causing this issue, LMMS could force mute upon import/load. eg, Flygel. The homepage itself doesn't seem to work, and it's impossible that Flygel ever be fixed.)

Monospace-V avatar Sep 16 '21 02:09 Monospace-V

Then is it unlikely the bug ever get fixed?

Never ever... Flygel is abandoned and closed source.

Also, because there are probably more VSTs causing this issue, LMMS could force mute upon import/load

Maybe something could be done to catch initial noise from a plugin, yes.

zonkmachine avatar Sep 16 '21 02:09 zonkmachine

Here is a fork of mda with updates https://github.com/pluginguru/mda-effects

zonkmachine avatar Apr 16 '24 21:04 zonkmachine