lmms icon indicating copy to clipboard operation
lmms copied to clipboard
verified publisher icon LMMS

Show knob value without clicking.

Open Gabrielxd195 opened this issue 5 years ago • 8 comments

Summary of improvements

Show the value of the knob without clicking on it

Justification

When I want to know the value of a knob I have to click on it, but in some cases when I click, sometimes by accident I move the mouse and change the value of the knob.

I know that we have the option of '' reset '' to restore the default value, but it would be more practical if the knob will show its value just by hovering over it like the other icons and buttons of the interface.

Sketch

Here is an image of the problem. Mostrar el valor de la perilla al pasar el puntero

Gabrielxd195 avatar Nov 11 '20 06:11 Gabrielxd195

Agree! And it ought to be a simple fix, if the super-class has an 'on-left-click-event'. Change that to on-mouse-over-event 'Off' could be an issue -though, unless there is a on-mouse-leave-event implemented. Only cravat i can see is a confusing flicker of values, as the mouse is moved over controllers, and that could be annoying. A short 'delay' before the tool-tip is displayed, would sort that(?)

musikBear avatar Nov 11 '20 14:11 musikBear

To implement this, one need to show and place Knob::s_textFloat with a QTimer to prevent flickers.

PhysSong avatar Feb 10 '21 04:02 PhysSong

I can take this issue, if no one is working on it.

salilra avatar Feb 17 '21 05:02 salilra

Thought about trying my hand at contributing to the project and came across this. It seems as though @salilra implemented the fix but it's not merged as of yet. Is there any work to be done regarding this issue?

justlog avatar Nov 07 '21 20:11 justlog

@salilra update? @justlog feel free to make your version.

Rossmaxx avatar May 07 '22 12:05 Rossmaxx

update?

https://github.com/LMMS/lmms/pull/5911

Monospace-V avatar May 23 '22 14:05 Monospace-V

Sorry folks I haven't been able to find time to fix this in a while. If anyone wants to take over, feel free

salilra avatar May 23 '22 15:05 salilra

I like this! I will try to give some help!

AngeloSorte avatar May 23 '22 16:05 AngeloSorte

Is anyone working on this issue I can give it a try as this will be my first time contributing to an open source project.

chaitanyak175 avatar Dec 22 '22 12:12 chaitanyak175

I could work on it...

MrTopom avatar Aug 28 '23 15:08 MrTopom

@MrTopom There seem to be an open PR for this issue. https://github.com/LMMS/lmms/pull/5911 I don't know what state it's in though.

zonkmachine avatar Aug 28 '23 15:08 zonkmachine

New comments in the PR https://github.com/LMMS/lmms/pull/5911

zonkmachine avatar Aug 28 '23 16:08 zonkmachine