Quests icon indicating copy to clipboard operation
Quests copied to clipboard

Optimise OnEntityDeath

Open HamtaBot opened this issue 2 years ago • 8 comments

Description of Bug

as you can see on the spark profiler under Wildstacker part, quest is being really heavy with OnEntityDeath even compared to other plugins listening to it image Would it be possible to reduce that usage , note that there is a ton of mobs being killed on my server everydays because its the main economy

Steps to Reproduce

not really doable with only 1 player

Environment

  • Minecraft version: 1.20.1
  • Server software: purpur
  • Quests version: 3.14.2

Agreements

  • [X] I am running the latest version of Quests
  • [X] I am certain this issue is unique and a similar issue is not currently open
  • [X] I am using a version of Minecraft which is supported by Quests

Other

No response

HamtaBot avatar Mar 10 '24 13:03 HamtaBot

Send the spark profiler url

Krakenied avatar Mar 10 '24 18:03 Krakenied

Send the spark profiler url

https://spark.lucko.me/pZhMvnWTZA

HamtaBot avatar Mar 10 '24 18:03 HamtaBot

Ill try to optimize that

Krakenied avatar Mar 11 '24 11:03 Krakenied

Also, you're using v3.14.2-4927673 - try updating to latest version, it has dedicated WildStacker support, however that doesn't fix the issue. ~~I would even recommend updating to latest push build https://github.com/LMBishop/Quests/actions/runs/8217559485/artifacts/1312096694~~ look below

Krakenied avatar Mar 13 '24 09:03 Krakenied

@HamtaBot please try with this build: https://github.com/LMBishop/Quests/actions/runs/8262666905/artifacts/1321740798

Krakenied avatar Mar 13 '24 09:03 Krakenied

@HamtaBot please try with this build: https://github.com/LMBishop/Quests/actions/runs/8262666905/artifacts/1321740798

i'll send a spark tomorrow

HamtaBot avatar Mar 13 '24 17:03 HamtaBot

@HamtaBot please try with this build: https://github.com/LMBishop/Quests/actions/runs/8262666905/artifacts/1321740798

https://spark.lucko.me/xAAtcyjZ4G better

HamtaBot avatar Mar 14 '24 18:03 HamtaBot

this is normal behavior ? image

HamtaBot avatar Mar 14 '24 18:03 HamtaBot

@Krakenied is it good ? there is not more you can do ? https://spark.lucko.me/xAAtcyjZ4G

HamtaBot avatar Apr 05 '24 14:04 HamtaBot

There is probably nothing more we can do

Krakenied avatar Apr 06 '24 01:04 Krakenied